Conversation
stevenhsd
reviewed
Sep 23, 2026
| entity: str, | ||
| record: Record, | ||
| error: ValidationError, | ||
| error_details: Optional[ |
Contributor
There was a problem hiding this comment.
Haven't investigated so might be harder than suggesting, but can't you pass the just the entities contract details to the row validator in the get_contract_metadata method?
Contributor
Author
There was a problem hiding this comment.
yep good spot - tested this and works with way fewer changes. Will revert the changes in here and apply the new change.
…cate column definitions" This reverts commit 7b5a6a7.
… duplicate field definitions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR of changes
Issue with defining different details for columns that have the same name across entities. Changed the structure of the data contract details to specify entity name as the first key and then columns afterwards.
What kind of changes does this PR introduce?
Tick all that apply
Please check if the PR fulfills these requirements